Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Mbed CoAP to be a feature #12962

Closed
wants to merge 2 commits into from
Closed

Change Mbed CoAP to be a feature #12962

wants to merge 2 commits into from

Conversation

teetak01
Copy link
Contributor

Summary of changes

Changes mbed-coap to be a feature.

Changing Mbed CoAP to feature allows application to control if it wants to link the Mbed OS version of CoAP library, or use externally provided version.

Impact of changes

No impact, as the feature is enabled by default.

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@anttiylitokola @yogpan01 @JanneKiiskila

@teetak01
Rename frameworks/mbed-coap to FEATURE_MBED_COAP
39e5dd1 
This change allows to turn CoAP as selectable component, instead of being
forced on to enabled.
@teetak01
Enable FEATURE_MBED_COAP by default
b0fca01 
This maintains backwards compatibility with existing users of mbed-coap.

Applications that do not need mbed-coap can disable it with

+            "target.features_remove": ["MBED_COAP"],

override.
@mergify mergify bot added the needs: work label May 13, 2020
@ciarmcom
Copy link
Member

@teetak01, thank you for your changes.
@yogpan01 @anttiylitokola @JanneKiiskila @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

@0xc0170
Copy link
Contributor

0xc0170 commented May 14, 2020

@teetak01 Can you fix astyle - probably needs to be in astyleignore file?

@0xc0170 0xc0170 requested review from bulislaw and removed request for a team May 14, 2020 16:09
@0xc0170
Copy link
Contributor

0xc0170 commented May 14, 2020

@bulislaw Please review (weren't the features later discouraged?)

@teetak01
Copy link
Contributor Author

What is the tool supported way to make a feature optional in such a way that other libraries AND application could disable it if is needed?

Ultimately I would prefer that mbed_lib.json file could have something like:

"target.features_remove": ["MBED_COAP"]

But this does seems to work only from mbed_app level. I was under impression that there is three-levels of overrides:

mbed_app > mbed_lib > targets.json

@mergify mergify bot added the needs: work label Jun 1, 2020
@mergify
Copy link

mergify bot commented Jun 1, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: review label Jun 1, 2020
@pan- pan- mentioned this pull request Jul 9, 2020
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 11, 2020

I'll close this one. It is not relevant anymore - we are still restructuring plus the new tools should allow us to build "not everything".

@0xc0170 0xc0170 closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttiylitokola anttiylitokola Awaiting requested review from anttiylitokola

@JanneKiiskila JanneKiiskila Awaiting requested review from JanneKiiskila

@yogpan01 yogpan01 Awaiting requested review from yogpan01

@bulislaw bulislaw Awaiting requested review from bulislaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teetak01 @ciarmcom @0xc0170